New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing host attribute to handle new Papertrail servers #2

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@madwork

madwork commented Aug 10, 2014

Hi,

Unfortunately Papertrail has added a new server logs2.papertrailapp.com (173.247.105.170), and I came across it! So, I added this new host attribute to the cookbook to manage that, with specs and also updated README/metadata.

bundle exec rake cookbook:test

@madwork

This comment has been minimized.

Show comment
Hide comment
@madwork

madwork Aug 10, 2014

With the new chef supermarket, some dependencies have to be updated, that's why the build failed on Travis. I used to manage that to run the tests, but there are somes updates to make:
Berkshelf should be updated to v3.1 to add the new source into the Berksfile, but there are conflicts with dependencies, like the cookbook-development gem, which should use strainer v3.4.0

madwork commented Aug 10, 2014

With the new chef supermarket, some dependencies have to be updated, that's why the build failed on Travis. I used to manage that to run the tests, but there are somes updates to make:
Berkshelf should be updated to v3.1 to add the new source into the Berksfile, but there are conflicts with dependencies, like the cookbook-development gem, which should use strainer v3.4.0

@motns

This comment has been minimized.

Show comment
Hide comment
@motns

motns Aug 13, 2014

Member

Hi @madwork - thanks for the pull request! You're right, the dependencies are massively out of date here, so no wonder the Travis build fails.

The things is, since we no longer use Papertrail, we kind of stopped updating this cookbook (see the notice in the Readme). Would you by any chance be interested in taking over as the maintainer? I could add you as a collaborator on Chef Supermarket so that you can publish new versions.
Alternatively if you're not interested, your changes look good to me, so I'm happy to merge them in now as they are (even with Travis failing) - I'm really busy these days, so I won't really have time to fix the dependencies any time soon (and get Travis passing).

Member

motns commented Aug 13, 2014

Hi @madwork - thanks for the pull request! You're right, the dependencies are massively out of date here, so no wonder the Travis build fails.

The things is, since we no longer use Papertrail, we kind of stopped updating this cookbook (see the notice in the Readme). Would you by any chance be interested in taking over as the maintainer? I could add you as a collaborator on Chef Supermarket so that you can publish new versions.
Alternatively if you're not interested, your changes look good to me, so I'm happy to merge them in now as they are (even with Travis failing) - I'm really busy these days, so I won't really have time to fix the dependencies any time soon (and get Travis passing).

@madwork

This comment has been minimized.

Show comment
Hide comment
@madwork

madwork Aug 15, 2014

Hi @motns,

Sorry, I completely missed the notice.

I find your cookbook really well and it fit perfectly to my needs, and yes, I would be interested in taking over as the maintainer.
However, there is a dependency with the cookbook-development gem and this gem must be updated too. Do you still use it for you recent cookbook ? Do you want keep it as a dependency ?

I'm a bit curious, you have stopped using Papertrail for an homemade solution ?

madwork commented Aug 15, 2014

Hi @motns,

Sorry, I completely missed the notice.

I find your cookbook really well and it fit perfectly to my needs, and yes, I would be interested in taking over as the maintainer.
However, there is a dependency with the cookbook-development gem and this gem must be updated too. Do you still use it for you recent cookbook ? Do you want keep it as a dependency ?

I'm a bit curious, you have stopped using Papertrail for an homemade solution ?

@gh2k

This comment has been minimized.

Show comment
Hide comment
@gh2k

gh2k Dec 3, 2014

I've taken over maintenance of this cookbook, and I've merged this into my fork. Thanks, @madwork

gh2k commented Dec 3, 2014

I've taken over maintenance of this cookbook, and I've merged this into my fork. Thanks, @madwork

@madwork

This comment has been minimized.

Show comment
Hide comment
@madwork

madwork Dec 3, 2014

@gh2k Awesome! 👍

madwork commented Dec 3, 2014

@gh2k Awesome! 👍

@madwork madwork closed this Dec 3, 2014

@madwork madwork deleted the madwork:add-host-attribute branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment