Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --no-cache support #214

Merged
merged 2 commits into from Oct 28, 2020
Merged

fix --no-cache support #214

merged 2 commits into from Oct 28, 2020

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Feb 25, 2020 •
edited

This change disables prestissimo when --no-cache flag is passed.
Regex is taken from https://github.com/composer/composer/blob/f154d5c09d69a6338d6a955bf51cc264d0448b3d/src/Composer/Cache.php#L62-L65

fixes #199

@coveralls
Copy link

coveralls commented Feb 25, 2020 •
edited

Coverage Status

Coverage increased (+0.1%) to 80.387% when pulling ef4ec0d on IonBazan:bugfix/no-cache into fb6724d on hirak:master.

kubawerlos
kubawerlos suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests to prove the fix works? Few positive and negative scenarios to show expected behaviour.

src/Plugin.php Show resolved Hide resolved
@IonBazan
Copy link
Contributor Author

IonBazan commented May 6, 2020

@kubawerlos Tests added :)

kubawerlos
kubawerlos approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 👍

@hirak hirak merged commit c2c9cba into hirak:master Oct 28, 2020
@IonBazan IonBazan deleted the bugfix/no-cache branch October 28, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edutrul edutrul edutrul left review comments

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error with --no-cache in composer 1.9
5 participants
@IonBazan @coveralls @edutrul @kubawerlos @hirak