fix: memleak in timeout w/ abort signal #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelcr
approved these changes
Oct 31, 2024
Collaborator
rafaelcr
left a comment
rafaelcr
left a comment
There was a problem hiding this comment.
Oh wow, excellent find! We should update all our APIs from this, they all use timeout
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 31, 2024
## [1.7.2](v1.7.1...v1.7.2) (2024-10-31) ### Bug Fixes * memleak in timeout w/ abort signal ([#32](#32)) ([d56a9ad](d56a9ad))
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the
timeoutfunction. When provided an AbortSignal, the event listeners were not cleared which results in memory leaks for long-lived AbortSignals/Controllers, and these error logs: