fix: report placeholder in prom metrics for invalid request paths#1867
Merged
fix: report placeholder in prom metrics for invalid request paths#1867
Conversation
|
Vercel deployment URL: https://stacks-blockchain-2ct4g3obb-blockstack.vercel.app 🚀 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1867 +/- ##
===========================================
+ Coverage 47.01% 71.76% +24.75%
===========================================
Files 92 92
Lines 11912 11911 -1
Branches 2624 2624
===========================================
+ Hits 5600 8548 +2948
+ Misses 5910 3209 -2701
+ Partials 402 154 -248 ☔ View full report in Codecov by Sentry. |
CharlieC3
reviewed
Feb 19, 2024
rafaelcr
approved these changes
Feb 19, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Feb 19, 2024
## [7.8.2](v7.8.1...v7.8.2) (2024-02-19) ### Bug Fixes * report placeholder in prom metrics for invalid request paths ([#1867](#1867)) ([7921488](7921488))
Contributor
|
🎉 This PR is included in version 7.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
blockstack-devops
pushed a commit
that referenced
this pull request
Feb 20, 2024
## [7.9.0-nakamoto.5](v7.9.0-nakamoto.4...v7.9.0-nakamoto.5) (2024-02-20) ### Bug Fixes * report placeholder in prom metrics for invalid request paths ([#1867](#1867)) ([7921488](7921488)) * **rosetta:** use /v2/fees/transaction for fee estimation ([b287b7b](b287b7b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([07339c0](07339c0))
Contributor
|
🎉 This PR is included in version 7.9.0-nakamoto.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1826
When a request path is invalid because it doesn't have a route handler, change the prometheus reporting so that the path name is the placeholder
<invalid_path>. This fixes the issue of very long path names, and fixes the issue of log spam from many unique invalid paths.