Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track app domain as event property within app-initiated flows #2904

Closed
markmhendrickson opened this issue Nov 23, 2022 · 3 comments · Fixed by #2912
Closed

Track app domain as event property within app-initiated flows #2904

markmhendrickson opened this issue Nov 23, 2022 · 3 comments · Fixed by #2912
Assignees

Comments

@markmhendrickson
Copy link
Collaborator

Whenever an app initiates a wallet flow for the user, we should include a new property for all events triggered within that flow that contains the domain of the initiating app.

For example:

  • App initiates user authentication
  • App initiates transaction signing

The property should be included from the point of initiation until the closing of the relevant wallet window, and it should be included only for events that are triggered within that specific flow (and not, for example, for events triggered simultaneously in a separate window open for the wallet).

It could be named something like referringAppDomain and should include the complete base URL of the referring app (e.g. https://example.org not example.org/path/to/page).

This will enable us to measure the amount and types of wallet usage driven by particular apps.

blockstack-devops pushed a commit that referenced this issue Dec 5, 2022
## [3.27.0](v3.26.0...v3.27.0) (2022-12-05)

### Features

* add get help menu item, closes [#2823](#2823) ([6e13f4c](6e13f4c))
* add option to easily transfer within same wallet ([f1b6ac6](f1b6ac6))
* allow tracking app initiating wallet flow, closes [#2904](#2904) ([d533d43](d533d43))
* bitcoin fees query ([9451f89](9451f89))

### Bug Fixes

* close other frames when wallet locks ([8788e01](8788e01))
* re-enable sentry, closes 2822 ([23776d4](23776d4))
* use existing data-testid values ([5194c20](5194c20))

### Internal

* add window.open lint rule ([0ed015b](0ed015b))
* reading search params outside react ([4e8d3dd](4e8d3dd))
* use type assertion ([1ac3fba](1ac3fba))
@markmhendrickson
Copy link
Collaborator Author

I'm reopening since I'm unable to see the flowInitiatorURL come through in production, and my sense is that we need to modify this to flowInitiatorDomain for it to be most useful in report generation.

image

@edu-stx
Copy link
Contributor

edu-stx commented Dec 12, 2022

Ended up using the referringAppDomain property, and didn't update the screenshot. Is referringAppDomain available in the dashboard?

We can set whatever name is most convenient.

I'll update the comment on the PR to match the code.

@markmhendrickson
Copy link
Collaborator Author

Note that we ended up using property origin instead of referringAppDomain or flowInitiatorDomain and the value appears to be reported accurately in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants