New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track app domain as event property within app-initiated flows #2904
Comments
edu-stx
added a commit
that referenced
this issue
Nov 28, 2022
edu-stx
added a commit
that referenced
this issue
Nov 28, 2022
edu-stx
added a commit
that referenced
this issue
Nov 30, 2022
edu-stx
added a commit
that referenced
this issue
Nov 30, 2022
edu-stx
added a commit
that referenced
this issue
Nov 30, 2022
kyranjamie
pushed a commit
that referenced
this issue
Dec 1, 2022
kyranjamie
pushed a commit
that referenced
this issue
Dec 1, 2022
kyranjamie
pushed a commit
that referenced
this issue
Dec 2, 2022
blockstack-devops
pushed a commit
that referenced
this issue
Dec 5, 2022
## [3.27.0](v3.26.0...v3.27.0) (2022-12-05) ### Features * add get help menu item, closes [#2823](#2823) ([6e13f4c](6e13f4c)) * add option to easily transfer within same wallet ([f1b6ac6](f1b6ac6)) * allow tracking app initiating wallet flow, closes [#2904](#2904) ([d533d43](d533d43)) * bitcoin fees query ([9451f89](9451f89)) ### Bug Fixes * close other frames when wallet locks ([8788e01](8788e01)) * re-enable sentry, closes 2822 ([23776d4](23776d4)) * use existing data-testid values ([5194c20](5194c20)) ### Internal * add window.open lint rule ([0ed015b](0ed015b)) * reading search params outside react ([4e8d3dd](4e8d3dd)) * use type assertion ([1ac3fba](1ac3fba))
Ended up using the We can set whatever name is most convenient. I'll update the comment on the PR to match the code. |
Note that we ended up using property |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Whenever an app initiates a wallet flow for the user, we should include a new property for all events triggered within that flow that contains the domain of the initiating app.
For example:
The property should be included from the point of initiation until the closing of the relevant wallet window, and it should be included only for events that are triggered within that specific flow (and not, for example, for events triggered simultaneously in a separate window open for the wallet).
It could be named something like
referringAppDomain
and should include the complete base URL of the referring app (e.g.https://example.org
notexample.org/path/to/page
).This will enable us to measure the amount and types of wallet usage driven by particular apps.
The text was updated successfully, but these errors were encountered: