Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backgroundPresets add contrast color #335

Merged

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Oct 19, 2022

Description

#328 provide a --contrast-test-color css variable, it will change with background color.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@codeflowapp
Copy link

codeflowapp bot commented Oct 19, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit ab457ad
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6358fa5c5fe6fe00093251e5
😎 Deploy Preview https://deploy-preview-335--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 42c7e60
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6358f41d0f22770008a70a23
😎 Deploy Preview https://deploy-preview-335--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit ab457ad
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6358fa5b3317ba0009a97b06
😎 Deploy Preview https://deploy-preview-335--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit ab457ad
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6358fa5b33182f0009e814b2
😎 Deploy Preview https://deploy-preview-335--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@faga295
Copy link
Contributor Author

faga295 commented Oct 20, 2022

now it can be used in iframe, and added some cypress tests

@Akryum Akryum merged commit c7ced23 into histoire-dev:main Oct 26, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants