Automating the "monitoring" part of gitGraber#14
Merged
Conversation
Contributor
Author
|
Also i forgot to add that the cron job that will be created will default to every 30 mins. |
Collaborator
|
Hi ! Thanks for your PR. We will have a look at this but it seems to be an interesting feature indeed. We will let you know soon, Thanks ! |
Collaborator
|
Thanks again @Abss0x7tbh ! |
Contributor
Author
|
Hey! Am glad that you liked my idea : ) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
First off, great work on gitGraber!
The README contains the following recommendation -
The above cron job will ensure regular execution of the script every 15 mins . This means that the user need not "repeat" the query with the same arguments, in short on adding the above cron job to the crontab the user can monitor the GitHub "query".
The only issue i see here is that this could very easily be automated i.e the user need not always add cron jobs manually for every query of theirs. So i wanted to automate this by giving a choice to the end user.
My PR does 3 simple things -
monitor()function & create a cron job with the same arguments passed by the user.Hope you like the idea.
Thanks!