Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Indicate that SQLSelectTableJoinConditions.Add(string, ComparisonOperator, string) is obsolete #20

Closed
hisystems opened this Issue Mar 4, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Owner

hisystems commented Mar 4, 2012

This function is only required for backward compatibility. All new functionality should utilise the new overloaded Add() function.

@ghost ghost assigned hisystems Mar 4, 2012

hisystems added a commit that referenced this issue Mar 4, 2012

Added support for conditions precedence in table join conditions. Closes
 #18.

SQLSelectTableJoinConditions objects can now be created and a collection of conditions can be added to an SQLSelectTableJoinConditions object to group a set of conditions and to ensure the sub-conditions are wrapped in parentheses and executed logically first as per the mathematical order of operations.

Removed the reference to the Friend SQLSelectTableJoinConditions.Parent property because this is not utilised by the library.

SQLSelectTableJoinConditions.Add(String, ComparisonOperator, String) is only accessible if used when the parent SQLSelectTableJoin is used and it remains only for backward compatibility reasons. Created issue #20 to indicate that this method should be marked as obsolete.

@hisystems hisystems closed this in e3786dc Mar 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment