Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ermögliche Fragen, die nur eine Checkbox als Antwort haben #1079

Merged
merged 16 commits into from
Nov 17, 2020

Conversation

kronn
Copy link
Member

@kronn kronn commented Nov 13, 2020

  • Implementation
  • Specs
  • Changelog
  • Squash whitespace/rubocop-commits

Fixes hitobito/hitobito_sjas#15

@kronn kronn requested a review from hupf November 13, 2020 16:53
@kronn kronn self-assigned this Nov 13, 2020
@kronn kronn force-pushed the feature/add-boolean-questions branch from 6d429f1 to f3e36ce Compare November 15, 2020 14:40
@kronn kronn marked this pull request as ready for review November 15, 2020 14:40
spec/controllers/events_controller_spec.rb Show resolved Hide resolved
app/models/event/question.rb Outdated Show resolved Hide resolved
config/locales/views.de.yml Outdated Show resolved Hide resolved
Copy link
Member

@hupf hupf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht sehr gut aus 👍
Einzig der Hilfetext könnte vielleicht noch etwas präzisiert werden.

Ansonsten, ready to merge (ich überlasse dies dir).

@kronn kronn merged commit 40c4933 into master Nov 17, 2020
@kronn kronn deleted the feature/add-boolean-questions branch November 17, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Questions als Boolean Checkbox
2 participants