New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tel: Link with phone numbers #202

Merged
merged 5 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@adriananderegg
Contributor

adriananderegg commented Mar 18, 2017

enable direct call from phone numbers
hyperlink "tel:012345678" is added to every phone number when displaying a person

this is especially helpfull on mobile devices.
see also iPhoneURLScheme from apple
https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/PhoneLinks/PhoneLinks.html

@RolandStuder RolandStuder requested a review from kronn Mar 20, 2017

@RolandStuder

This comment has been minimized.

Show comment
Hide comment
@RolandStuder

RolandStuder Mar 20, 2017

Member

@kronn Bitte gleich mergen, wenn das ok ist.

Member

RolandStuder commented Mar 20, 2017

@kronn Bitte gleich mergen, wenn das ok ist.

@kronn

I would like to see the spec* extended/adapted for this change.

  • spec/decorators/contactable_decorator_spec.rb, lines 58 - 74
@adriananderegg

This comment has been minimized.

Show comment
Hide comment
@adriananderegg

adriananderegg Mar 23, 2017

Contributor

@kronn spec/decorators/contactable_decorator_spec.rb wie gewünscht angepasst an das neue Format

Contributor

adriananderegg commented Mar 23, 2017

@kronn spec/decorators/contactable_decorator_spec.rb wie gewünscht angepasst an das neue Format

@kronn

kronn approved these changes Mar 23, 2017

@kronn

This comment has been minimized.

Show comment
Hide comment
@kronn
Member

kronn commented Mar 23, 2017

@kronn kronn merged commit b14bf91 into hitobito:master Mar 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

psunix pushed a commit that referenced this pull request Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment