Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice lists: display all invoices by default and make ends of range inclusive #2047

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

lukas-buergi
Copy link
Contributor

Behaviour before: Invoice lists have the current year (excluding first and last day) preselect, so when looking at old invoice lists, the list is empty and the fact that the end days are not including is surprising.

Behaviour after: Invoice lists by default show invoices starting at the beginning of the year when the list was created, to the end of the current year. The first and last day of the range is included in both the default range and when a different range is chosen by the user.

Tests: A few tests failed in my local run, but they don't look related to this change.

@lukas-buergi
Copy link
Contributor Author

Should I force-push so the small fix isn't a commit on its own?

@carlobeltrame
Copy link
Member

Force pushing your feature branch is fine with us.

@carlobeltrame
Copy link
Member

Thank you very much for the contribution!

@carlobeltrame carlobeltrame merged commit 7cc8b5c into hitobito:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants