Fix totp drift #2052
Merged
Fix totp drift #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverer
force-pushed
the
fix-totp-drift
branch
3 times, most recently
from
9ca66c5 to
3467571
Compare
cleverer
force-pushed
the
fix-totp-drift
branch
from
3467571 to
b985123
Compare
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1830
Die library erlaub auch ein
drift_ahead(https://rubydoc.info/github/mdp/rotp/master/ROTP%2FTOTP:verify). Daraus schliesse ich, dass die drift parameter nur das jeweilige ende es slots verschieben und nicht den ganzen slot.Der Code akzeptiert einen Time-Drift von maximal +/- 15 Sekunden. Das RFC zum TOTP spricht von bis zu 60s Verschiebung… (6. Resynchronization, https://www.ietf.org/rfc/rfc6238.txt). Ich denke das sollte aber reichen um das Problem zu umgehen.