Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix + Failure handling #3

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Fix + Failure handling #3

merged 1 commit into from
Feb 6, 2018

Conversation

edwardsd97
Copy link
Contributor

  • Fixed issue where first video would go to "converted-"
  • Added some handling for if the conversion fails
    • logs the resulting error code
    • renames the result -video.mp4-failed so that the user does not see it as a successful convert and copy it over there valid video with a corrupt one

@edwardsd97
Fix + Failure handling
0649e87 
- Fixed issue where first video would go to "converted-"
- Added some handling for if the conversion fails
   - logs the resulting error code
   - renames the result <rom>-video.mp4-failed so that the user does not see it as a successful convert and copy it over there valid video with a corrupt one
@edwardsd97
Copy link
Contributor Author

Any thoughts on this? If you would rather just leave it be let me know so I can clean out my forked repo.

@hiulit
Copy link
Owner

hiulit commented Feb 6, 2018 •
edited
Loading

Hey, sorry! I didn't have time to check it yet. I'll take a look at it today. At first glance, it looks good :)

@hiulit hiulit merged commit 0649e87 into hiulit:master Feb 6, 2018
@hiulit
Copy link
Owner

hiulit commented Feb 6, 2018

Thanks! I've merged your PR. I've made some little changes:

  • Added double quotes to $? and $result.
  • Removed $result when status is FAILED because it will always be 1 and it's not important feedback to the user.
  • Changed $result to $result_value (because that's what I always use. Personal choice :P)

@edwardsd97
Copy link
Contributor Author

Sounds good thanks. Actually I was getting result number 134 or something if I recall. Didn't know what it meant but thats what i was getting.

At any rate. Thanks again for this!

@hiulit
Copy link
Owner

hiulit commented Feb 6, 2018

Thanks to you for bringing this up and for helping me! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardsd97 @hiulit