Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter getting started #67

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@chrishuppertz
Copy link
Contributor

chrishuppertz commented Oct 3, 2019

Hi @leisim,

I just started to use Hive in my own flutter project and noticed that the readme part of getting started in flutter could have more details which dependencies are required besides hive. I have added these. Feel free to merge.

Best
Christian

@leisim

This comment has been minimized.

Copy link
Member

leisim commented Oct 3, 2019

Thanks for this pull request. Something seems to have gone wrong with one of your commits. The two benchmark pngs have been corrupted.

@chrishuppertz

This comment has been minimized.

Copy link
Contributor Author

chrishuppertz commented Oct 3, 2019

wups... did not notice that. I'll check it what went wrong.

Ar1lon
@chrishuppertz

This comment has been minimized.

Copy link
Contributor Author

chrishuppertz commented Oct 3, 2019

The problem should be solved. It was an issue with the autodetction for crlf and lf conversion in the .gitattributes for windows. I readded the png and added the binary attribute to the .gitattributes.

@leisim

This comment has been minimized.

Copy link
Member

leisim commented Oct 3, 2019

Perfect, thanks!

@leisim leisim merged commit e9c6515 into hivedb:master Oct 3, 2019
1 check passed
1 check passed
test-hive (vm)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.