Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ping request response interceptor #74

Open
wants to merge 28 commits into
base: master
from

Conversation

@RobinAtherton
Copy link
Contributor

commented Aug 13, 2019

Motivation

Resolves the absence of a possibility for extension developers to intercept ping requests and ping responses.

Changes

Added an implementation for ping request and ping response interceptors.

@cla-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @RobinAtherton on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@RobinAtherton

This comment has been minimized.

This comment has been minimized.

Copy link
Member

replied Aug 13, 2019

I‘d leave this out

This comment has been minimized.

Copy link
Contributor Author

replied Aug 13, 2019

Okay i'll remove it

@cla-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @RobinAtherton on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @RobinAtherton on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@MagiErber

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@cla-bot check

@cla-bot

This comment has been minimized.

Copy link

commented Aug 14, 2019

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Aug 14, 2019
@RobinAtherton RobinAtherton requested a review from Florian-Limpoeck Aug 14, 2019
@Florian-Limpoeck

This comment has been minimized.

Copy link
Member

commented on 2d2366c Sep 6, 2019

@{622f5493-b6d1-4ca6-8b46-4c8294a61258,Robin Atherton} you did not fix any of the issues i mentioned. Please fix them and then resolve them in upsource.

@schaebo

This comment has been minimized.

formatting

@schaebo schaebo self-requested a review Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.