Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

When I wait for the component to disappear implementation is invalid. #6

Closed
benwaine opened this Issue · 8 comments

4 participants

Ben Waine Simon Rycroft Phillip Hicks James Bodkin
Ben Waine

As described in this commit comment.

ad7274d#commitcomment-1975556

Phil, can you take a look?

Phillip Hicks philliphicks was assigned
Simon Rycroft
Ben Waine

Hi Simon - I've checked and you are no longer a member of our team on github. If you are still receiving updates on OD projects you may have to adjust your notification center settings.

https://github.com/settings/notifications

Thanks,

Ben

Simon Rycroft
Phillip Hicks

Hi,

Fixed in commit f46380c

Will add some more unit tests when I have more time.

Cheers,

Phil

James Bodkin
Owner

Hello Simon,

I have double checked that you are no longer part of the team. As this is a public repo, you will need to unwatch the repo yourself at https://github.com/watching

Thanks,

James

Phillip Hicks philliphicks reopened this
Phillip Hicks

Reopened this as the unit tests need updating. Hopefully Ben will look into it this afternoon!

Simon Rycroft
Ben Waine benwaine referenced this issue from a commit
Ben Waine Rewrote the 'waitForComponentShould' step in reponse to #6
The component now takes a number of additional edge cases into
account.

disappear - element off the page / element hidden
appear - element on the page and visible

Added a range of additional unit and integration tests.

Ammended the examples to include a pause before manipulating
the dom. The examples now reflect the functionality.
33a8b7c
Phillip Hicks

Fixed by Ben in 33a8b7c. Much more robust now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.