Fix/add locale option #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for uselessdev-datepicker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tomchentw
commented
May 25, 2022
tomchentw
force-pushed
the
fix/add-locale-option
branch
from
713ef0c to
8904e68
Compare
hiwllc
requested changes
May 25, 2022
|
@tomchentw thanks again. About the |
tomchentw
force-pushed
the
fix/add-locale-option
branch
from
8904e68 to
660e9f7
Compare
|
@uselessdev I've updated the PR. Please review. If it's not too much trouble, would you mind cutting a release after merging this? Thank you 🙏 |
hiwllc
approved these changes
May 25, 2022
Yes, I'll make a new release 😊 |
|
@tomchentw I just published the new release https://github.com/uselessdev/datepicker/releases/tag/v2.4.0 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39 .
Notes
Good day, @uselessdev. Not until I tried to address #39 did I realize that the interfaces already have the
weekStartsOnoption. This PR adds thelocaleto the date-fn options along with some existingweekStartsOnoption. I'm not sure if you like this approach though so please feel free to ditch this PR.Although
date-fnsalso supports specifyinglocaleandweekStartsOnin the options in the same time, I personally prefer keeping only thelocaleoption in the interface for simplicity. But this involves a breaking change so let's discuss it first.Pros and Cons of Keeping Only the
localePros
Cons