Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freenowtech add team label #120

Merged
merged 3 commits into from Dec 18, 2019
Merged

Freenowtech add team label #120

merged 3 commits into from Dec 18, 2019

Conversation

@hjacobs
Copy link
Owner

hjacobs commented Dec 18, 2019

Replaces #118

vaegt and others added 3 commits Dec 16, 2019
This enables the usage of the teams overview without having an application registry,
instead it uses a specifiable label on the pod to determine the team.
@hjacobs hjacobs mentioned this pull request Dec 18, 2019
@hjacobs hjacobs merged commit 9f29ac5 into master Dec 18, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.8%) to 65.572%
Details
@hjacobs

This comment has been minimized.

Copy link
Owner Author

hjacobs commented Dec 19, 2019

This PR was broken as the function signature was changed (and no tests exist to catch this). I now added mypy to at least catch these problems: https://github.com/hjacobs/kube-resource-report/blob/master/Makefile#L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.