This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Add propagation_policy option to APIObject.delete() method #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding hjacobs/kube-janitor#28
As it turned out, the issue was the following.
When you delete an object of
apps/v1
version, its dependent objects are deleted. But when you delete an object ofextensions/v1beta1
, its dependent objects are orphaned. Here is the ref to docs about this behavior: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#setting-the-cascading-deletion-policySo, when do this:
its dependent objects are orphaned.
If you change
version
toapps/v1
then everything is ok.Now, Kubernetes API allow you to specify
propagationPolicy
with possible values “Orphan”, “Foreground”, or “Background”. Example:So, I added optional argument
propagation_policy
with default valueNone
, so that if someone want to explicitly specify policy they can do that with this flag.