Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify arguments of `declare_PRAGMA` protocol. #23

Closed
hkoba opened this issue Dec 4, 2016 · 0 comments

Comments

@hkoba
Copy link
Owner

commented Dec 4, 2016

I want to change the arguments specification of declare_... protocol like:

MyExporter->declare_foo($opts_or_callpack);

$opts_or_callpack can be either a string or a HASH reference (which has fields defined in MOP4Import::Opts).

Current declare_... protocol gives two mandatory arguments like below:

MyExporter->declare_foo($opts, $callpack);

Backstory

With current spec, $callpack (package name of caller) is given as an explicit argument. I expected this could help programmers who writes protocol handlers (declare_foo in above case) for simple cases.

But then I understand there are much more programmers who calls these handlers than the writers of handlers.

So I decided to introduce this breaking change.

@hkoba hkoba added the api-change label Dec 4, 2016

hkoba added a commit that referenced this issue Jul 8, 2017
hkoba added a commit that referenced this issue Jul 11, 2017
hkoba added a commit that referenced this issue Aug 31, 2017

@hkoba hkoba self-assigned this Aug 31, 2017

hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Aug 31, 2017
hkoba added a commit that referenced this issue Sep 11, 2017

@hkoba hkoba closed this Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.