Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`configure()` silently ignores options with wrong chars which is too bad #66

Closed
hkoba opened this issue Jun 9, 2019 · 0 comments

Comments

@hkoba
Copy link
Owner

commented Jun 9, 2019

currently, fields like api.token are allowed but configure() silently drop them. This is quite bad. Let's fix it.

@hkoba hkoba added the bug label Jun 9, 2019

@hkoba hkoba self-assigned this Jun 9, 2019

hkoba added a commit that referenced this issue Jun 9, 2019
Fix [GH #66] - configure should accept options like `api.token`
* Now only private options (starting with `_`) are rejected explicitly.

@hkoba hkoba closed this Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.