Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YATT::Lite->render() should behave consistently with YATT::Lite::Factory->render() #129

Closed
hkoba opened this issue Feb 23, 2018 · 0 comments
Closed

YATT::Lite->render() should behave consistently with YATT::Lite::Factory->render() #129

hkoba opened this issue Feb 23, 2018 · 0 comments
Assignees
@hkoba
Labels
API-change bug

Comments

@hkoba
Copy link
Owner

hkoba commented Feb 23, 2018

#45 changed YATT::Lite::Factory->render() but not YATT::Lite->render().
@hkoba hkoba self-assigned this Feb 23, 2018
hkoba added a commit that referenced this issue Feb 27, 2018
@hkoba
For [GH #129] [GH #45] - Just introduce new option render_as_bytes.…
02ce499 
… Tests and Impls come next.
hkoba added a commit that referenced this issue Feb 27, 2018
@hkoba
For [GH #129] [GH #45] - Add tests for render_as_bytes option on/off.
7e95f80
hkoba added a commit that referenced this issue Feb 27, 2018
@hkoba
Fixes [GH #129] [GH #45] - render() now returns utf-8 by default.
9c207c6 
* To revert old behavior, pass `render_as_bytes` option.
@hkoba hkoba closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkoba hkoba

Labels
API-change bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkoba