New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue #2

Open
fniessen opened this Issue Mar 4, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@fniessen
Copy link

fniessen commented Mar 4, 2017

Hello. And thanks! This is it. This is the package we need to highlight whatever, easily, and get those highlights over hl-line mode.

This package becomes critical for analyzing problems in log files, especially in huge log files. I'm speaking here of files of 400 MB for example.

Opening these in Emacs 25 takes a couple of seconds when hl-anything is not enabled. When it is, it seems to never stop: I entered C-g after 8 minutes, and got this profiler-report (which I launched just before):

+ command-execute                                                                      443621  99%
+ ...                                                                                     309   0%
+ redisplay_internal (C function)                                                         160   0%
+ timer-event-handler                                                                      16   0%
  tooltip-show-help-non-mode                                                                1   0%

I was expecting more info. Dunno what happened here.

For info, I even tried with:

(setq hl-highlight-save-file nil)

for the case it would try to reapply old highlights, and be slow because of that. No visible impact.

(My current Emacs config is available at https://github.com/fniessen/emacs-leuven/blob/master/emacs-leuven.el)

Any idea how I can make hl-anything usable in big text files?

@boyw165

This comment has been minimized.

Copy link
Member

boyw165 commented Mar 4, 2017

My first guess would be it's because it tries to search whole text buffer for certain regex instead of a little window of the text buffer.

@fniessen

This comment has been minimized.

Copy link

fniessen commented Mar 4, 2017

Do you think you can do something about it? (and are you ready to do so? ;-))

@boyw165

This comment has been minimized.

Copy link
Member

boyw165 commented Mar 6, 2017

Well, I'm afraid not. I'm looking for someone else who could help me with it. Cause it has been a long time for me not using Emacs as the main coding editor. I use AndroidStudio most and VSCode sometimes. I got a full-time job and also am studying couple online courses at the meanwhile. I like the idea of this plugin (it's not easy to write one in the AndroidStudio, but probably easy for VSCode with better performance). If you'd like to help me to improve it, I think I'm ok to arrange a Google Hangout for explaining the original design with you.

@fniessen

This comment has been minimized.

Copy link

fniessen commented Mar 6, 2017

Too bad. Can't be of any help now, running after time for too long. And still under pressure for some period. Apart from time, it may also need experience which I don't have either.
Thanks anyway for what you already have done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment