New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default set of bindings for non-evil users #641

Open
wants to merge 1 commit into
base: develop
from

Conversation

4 participants
@UndeadKernel
Contributor

UndeadKernel commented Jun 1, 2018

If the flag +bindings is set in the default module, choose a default set of bindings based on whether evil is an active module or not.

@hlissner

This comment has been minimized.

Show comment
Hide comment
@hlissner

hlissner Jun 1, 2018

Owner

Good work!

@jwintz What do you think? (Being an evil user, I'm not a good judge for a non-evil keybinding scheme)

Owner

hlissner commented Jun 1, 2018

Good work!

@jwintz What do you think? (Being an evil user, I'm not a good judge for a non-evil keybinding scheme)

@UndeadKernel

This comment has been minimized.

Show comment
Hide comment
@UndeadKernel

UndeadKernel Jun 1, 2018

Contributor

I'm trying to keep this PR updated to the latest develop. It's difficult to keep-up with your updates @hlissner!

Stop commiting for a few minutes! Nah, just a joke. Commit all you can for Skynet needs a descent operating system that is connected to planet mars and hell :D

P.S.: The travis scripts cannot find emacs 26 pretest now. I guess it should be updated to use emacs 26 proper.

Contributor

UndeadKernel commented Jun 1, 2018

I'm trying to keep this PR updated to the latest develop. It's difficult to keep-up with your updates @hlissner!

Stop commiting for a few minutes! Nah, just a joke. Commit all you can for Skynet needs a descent operating system that is connected to planet mars and hell :D

P.S.: The travis scripts cannot find emacs 26 pretest now. I guess it should be updated to use emacs 26 proper.

@hlissner hlissner added this to the 2.1.1 milestone Jun 1, 2018

@hlissner

This comment has been minimized.

Show comment
Hide comment
@hlissner

hlissner Jun 1, 2018

Owner

@UndeadKernel Quite right! The travis tests are fixed now.

I've slated the merge for this PR for 2.1.1 now that 2.1 is just on the horizon, but I look forward to including it in Doom!

Owner

hlissner commented Jun 1, 2018

@UndeadKernel Quite right! The travis tests are fixed now.

I've slated the merge for this PR for 2.1.1 now that 2.1 is just on the horizon, but I look forward to including it in Doom!

@Oghma

This comment has been minimized.

Show comment
Hide comment
@Oghma

Oghma Jun 2, 2018

I believe the org section should be

;; Org related bindings
 (:prefix "C-c o"
   "s"     #'org-caldav-sync
   "a a"   #'org-agenda
   "a t"   #'org-todo-list
   "a m"   #'org-tags-view
   "a v"   #'org-search-view
   "c"     #'org-capture
   "C"     (λ! (require 'org-capture) (call-interactively #'org-capture-goto-target))
   "b"     #'org-iswitchb
   "e l b" #'org-beamer-export-to-latex
   "e l B" #'org-beamer-export-as-latex
   "e l P" #'org-beamer-export-to-pdf
   "l"     #'org-store-link)

Oghma commented Jun 2, 2018

I believe the org section should be

;; Org related bindings
 (:prefix "C-c o"
   "s"     #'org-caldav-sync
   "a a"   #'org-agenda
   "a t"   #'org-todo-list
   "a m"   #'org-tags-view
   "a v"   #'org-search-view
   "c"     #'org-capture
   "C"     (λ! (require 'org-capture) (call-interactively #'org-capture-goto-target))
   "b"     #'org-iswitchb
   "e l b" #'org-beamer-export-to-latex
   "e l B" #'org-beamer-export-as-latex
   "e l P" #'org-beamer-export-to-pdf
   "l"     #'org-store-link)
@UndeadKernel

This comment has been minimized.

Show comment
Hide comment
@UndeadKernel

UndeadKernel Jun 3, 2018

Contributor

@Oghma You are indeed correct. I'll fix it tomorrow.

Contributor

UndeadKernel commented Jun 3, 2018

@Oghma You are indeed correct. I'll fix it tomorrow.

Add a default set of bindings for non-evil users
If the flag +bindigns is set for the 'default' module,
choose the bindings based on whether 'evil' is an active
module or not.

@hlissner hlissner added the modules label Jul 29, 2018

@hlissner

This comment has been minimized.

Show comment
Hide comment
Owner

hlissner commented Jul 31, 2018

@seanfarley

This comment has been minimized.

Show comment
Hide comment
@seanfarley

seanfarley Sep 29, 2018

Oh, wow, I just found this (and am glad because I was about to duplicate some of this work)! Is there any way to get this PR picked up again possibly?

seanfarley commented Sep 29, 2018

Oh, wow, I just found this (and am glad because I was about to duplicate some of this work)! Is there any way to get this PR picked up again possibly?

@UndeadKernel

This comment has been minimized.

Show comment
Hide comment
@UndeadKernel

UndeadKernel Sep 29, 2018

Contributor
Contributor

UndeadKernel commented Sep 29, 2018

@seanfarley

This comment has been minimized.

Show comment
Hide comment
@seanfarley

seanfarley Sep 29, 2018

Ah, makes sense, @UndeadKernel thanks~! I'm just now switching from my handcrafted lisp to doom so it'll take a bit to adjust to these keybindings (though from reading them they look great).

seanfarley commented Sep 29, 2018

Ah, makes sense, @UndeadKernel thanks~! I'm just now switching from my handcrafted lisp to doom so it'll take a bit to adjust to these keybindings (though from reading them they look great).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment