Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Embrace JDK 1.5 compatibility #22

Closed
jochenberger opened this Issue Mar 18, 2011 · 6 comments

Comments

Projects
None yet
2 participants
Collaborator

jochenberger commented Mar 18, 2011

Source and target compatibility are set to 1.5 in the build file but there are several occurrences of @override annotations on interface method implementations. I'll happily provide a patch/pull request but I wanted to make sure that you still intend to use 1.5 as the source level.

Owner

hlship commented Apr 1, 2011

TapX isn't limited the way Tapestry is ... there's no reason for you
to submit patches if you'd rather contribute directly. No votes, I
can just do it by fiat ... its my own little project. However, you
must do so with the knowledge that much of TapX will eventually be
repackaged and refacted into Apache Tapestry, with the ASF copyright.

On Fri, Mar 18, 2011 at 12:40 AM, jochenberger
reply@reply.github.com
wrote:

Source and target compatibility are set to 1.5 in the build file but there are several occurrences of @override annotations on interface method implementations. I'll happily provide a patch/pull request but I wanted to make sure that you still intend to use 1.5 as the source level.

Reply to this email directly or view it on GitHub:
#22

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Collaborator

jochenberger commented Apr 4, 2011

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go.
And, ASL is fine by me.

Owner

hlship commented Apr 4, 2011

No, I'm keen for keeping 1.5 compatibility.

On Mon, Apr 4, 2011 at 1:33 AM, jochenberger
reply@reply.github.com
wrote:

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go.
And, ASL is fine by me.

Reply to this email directly or view it on GitHub:
#22 (comment)

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Owner

hlship commented Apr 4, 2011

You now have direct commit rights. Please try to keep the copyright
headers up to date.

On Mon, Apr 4, 2011 at 9:24 AM, Howard Lewis Ship hlship@gmail.com wrote:

No, I'm keen for keeping 1.5 compatibility.

On Mon, Apr 4, 2011 at 1:33 AM, jochenberger
reply@reply.github.com
wrote:

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go.
And, ASL is fine by me.

Reply to this email directly or view it on GitHub:
#22 (comment)

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

Collaborator

jochenberger commented Apr 5, 2011

Thanks. Sorry, that confused me so much that I just pushed a branch to the wrong remote. I hope, I didn't break anything. Should be okay again.

Owner

hlship commented Apr 5, 2011

Convert code to use JDK 1.5 semantics for use of @override annotation (on extended methods of super-classes, not implemented interface methods)

Closed by eea1c9b

@hlship hlship closed this Apr 5, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment