Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Embrace JDK 1.5 compatibility #22

Closed
jochenberger opened this Issue · 6 comments

2 participants

@jochenberger
Collaborator

Source and target compatibility are set to 1.5 in the build file but there are several occurrences of @Override annotations on interface method implementations. I'll happily provide a patch/pull request but I wanted to make sure that you still intend to use 1.5 as the source level.

@hlship
Owner
@jochenberger
Collaborator

I just wanted to make sure that you still want to support building with an 1.5 JDK. I'd rather not submit patches that head into a completely different way than where you intend the project to go.
And, ASL is fine by me.

@hlship
Owner
@hlship
Owner
@jochenberger
Collaborator

Thanks. Sorry, that confused me so much that I just pushed a branch to the wrong remote. I hope, I didn't break anything. Should be okay again.

@hlship
Owner

Convert code to use JDK 1.5 semantics for use of @Override annotation (on extended methods of super-classes, not implemented interface methods)

Closed by eea1c9b

@hlship hlship closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.