New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small changes #1

Merged
merged 5 commits into from Jul 18, 2011

Conversation

Projects
None yet
2 participants
@chrislo
Copy link
Contributor

chrislo commented Jul 16, 2011

Enjoying having a look at this project - very interesting and something I have an immediate use for. Thank you!

I've fixed a few small things. I see the tests for matrix multiplication and failing - is that something you are working on?

@hmcfletch

This comment has been minimized.

Copy link
Owner

hmcfletch commented Jul 16, 2011

I am actually in the process of changing some of the matrix multiplication functionality. I'll be adding the ability for a matrix to be specified as either row major or column major. In the multiplication the second matrix will always be converted to column major before multiplying. The cost of converting is almost always out weighed by the saving in the inner loop of the multiplication.

The rest of the code is also in a very unstable and pre-release state. There is still a long ways to go and am appreciate of the help. I'm glad that you have a use for it and will take a closer look at the pull request tomorrow. Thanks for submitting it. I'll probably work a little more actively on it knowing that someone is using it. :o)

@chrislo

This comment has been minimized.

Copy link
Contributor

chrislo commented Jul 16, 2011

Thank you! It sounds like a good idea to store the matrix in that format, it sounds like it would help to optimize that inner loop.

The pull request is just some rake helpers and so on. Let me know if you need any help with the rest of the code, I'm starting to get my head round it now! There's no great sparse matrix bindings for ruby, and no pure-ruby implementations as far as I can tell, so it would be good to get this working well.

Thank you for your efforts!

Chris

hmcfletch added a commit that referenced this pull request Jul 18, 2011

@hmcfletch hmcfletch merged commit 085dfe1 into hmcfletch:master Jul 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment