Send payment update message after creating case from exception record #673
Conversation
…creating-case-from-exception-record
| data.put("scanOCRData", TestCaseBuilder.ocrDataEntry("key", "value")); | ||
| data.put(ExceptionRecordFields.CONTAINS_PAYMENTS, YesNoFieldValues.NO); // no payments! | ||
| data.put(ExceptionRecordFields.ENVELOPE_ID, envelopeId); | ||
| data.put(ExceptionRecordFields.PO_BOX_JURISDICTION,jurisdiction); |
There was a problem hiding this comment.
building case data can be extracted and used in 2 tests
There was a problem hiding this comment.
This is bound to happen some time for sure. It's all over the place. I've started in separate branch but never had a chance to progress further as more changes coming in
|
|
||
| boolean containsPayments = | ||
| Objects.equals( | ||
| exceptionRecord.getData().get(ExceptionRecordFields.CONTAINS_PAYMENTS).toString(), |
There was a problem hiding this comment.
Can we extract exceptionRecord.getData() into a variable ? It’s repeated thrice
| private final CoreCaseDataApi ccdApi; | ||
|
|
||
| public CreateCaseCallbackService( | ||
| CreateCaseValidator validator, | ||
| ServiceConfigProvider serviceConfigProvider, | ||
| TransformationClient transformationClient, | ||
| AuthTokenGenerator s2sTokenGenerator, | ||
| PaymentsPublisher paymentsPublisher, |
There was a problem hiding this comment.
If to just reduce line change count then no point - payment happened after ccd api call + extra addition to argument list. But I'm just being picky here
There was a problem hiding this comment.
didn't realise we were sorting class dependencies by usage order ;)
There was a problem hiding this comment.
we're not. just thought i'm gonna be picky and guess the reason
| .map(exceptionRecord -> createNewCase( | ||
| exceptionRecord, | ||
| serviceConfigItem, | ||
| request.isIgnoreWarnings(), | ||
| idamToken, | ||
| userId | ||
| userId, | ||
| exceptionRecordData |
There was a problem hiding this comment.
Makes no point in having exception record created prior. Can be reviewed later
There was a problem hiding this comment.
sadly exceptionRecord is the request for transformation endpoint, not entire exception record we get from CCD
| data.put("scanOCRData", TestCaseBuilder.ocrDataEntry("key", "value")); | ||
| data.put(ExceptionRecordFields.CONTAINS_PAYMENTS, YesNoFieldValues.NO); // no payments! | ||
| data.put(ExceptionRecordFields.ENVELOPE_ID, envelopeId); | ||
| data.put(ExceptionRecordFields.PO_BOX_JURISDICTION,jurisdiction); |
There was a problem hiding this comment.
This is bound to happen some time for sure. It's all over the place. I've started in separate branch but never had a chance to progress further as more changes coming in
…creating-case-from-exception-record
| jurisdiction | ||
| ) | ||
| ); | ||
| paymentsPublisher.send( |
There was a problem hiding this comment.
it did raise me an eyebrow before 🙃
…creating-case-from-exception-record
…creating-case-from-exception-record
|
closing and opening a new one - helm issues. |
https://tools.hmcts.net/jira/browse/BPS-824