Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdm 2523 sql injection fix #394

Merged
merged 10 commits into from Jun 10, 2019
Merged

Rdm 2523 sql injection fix #394

merged 10 commits into from Jun 10, 2019

Conversation

MSancaktutar
Copy link
Contributor

@MSancaktutar MSancaktutar commented Mar 6, 2019

Copy link
Contributor

@rafalkalita rafalkalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 6, 2019 15:19 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 6, 2019 15:24 Abandoned
Copy link
Contributor

@mario-paniccia mario-paniccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 6, 2019 15:58 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 6, 2019 16:26 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 6, 2019 18:02 Inactive
@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   95.27%   95.28%   +<.01%     
==========================================
  Files         296      297       +1     
  Lines        6712     6718       +6     
  Branches      398      398              
==========================================
+ Hits         6395     6401       +6     
  Misses        317      317
Impacted Files Coverage Δ
...asedetails/search/SearchQueryFactoryOperation.java 100% <100%> (ø) ⬆️
...cts/ccd/data/casedetails/search/SortDirection.java 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f2858...a83fd48. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 6, 2019 22:54 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 7, 2019 13:23 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 requested a deployment to preview March 15, 2019 13:21 Abandoned
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 18, 2019 13:25 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 20, 2019 13:29 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview March 27, 2019 13:25 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 1, 2019 13:37 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 24, 2019 15:45 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview April 26, 2019 13:37 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 1, 2019 13:39 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 3, 2019 13:41 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 8, 2019 09:35 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 8, 2019 13:09 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 8, 2019 14:35 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 11, 2019 13:36 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 20, 2019 09:27 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 21, 2019 16:23 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview May 23, 2019 13:27 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview June 5, 2019 13:26 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview June 6, 2019 12:50 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview June 7, 2019 13:38 Inactive
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview June 10, 2019 08:38 Inactive
@veeresha-hmcts
Copy link
Contributor

Verified locally and ready for merge.

@hemantt hemantt merged commit 4b3dff4 into master Jun 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the RDM-2523_SQL_Injection_Fix branch June 10, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants