Skip to content

hmorales

  • Joined on Apr 12, 2010
Apr 12, 2016
Mar 9, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

Test code should not be embedded into our code base.

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

For Verify we have one single response where with PhoneID we have one per endpoint. We should have a similar pattern here for sms, voice, twoway, etc.

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

Not crazy about having the testing so tightly integrated into the codebase. Please remove the testing service concept and we will just include samp…

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

I noticed that in several places you are introducing new code that does not follow Java naming convention. Is this because you plan to do it all in #…

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

Add ucid to standard.

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

We should remove these comments.

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

Why is this not final?

Mar 8, 2016
hmorales commented on pull request TeleSign/java_telesign#48
@hmorales

I just confirmed that the documentation for ND had the wrong domain. This will be under the rest.telesign.com domain. Please update.

Something went wrong with that request. Please try again.