New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set unique arrange id for each panel #112

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@GuangchuangYu
Copy link

GuangchuangYu commented Apr 24, 2018

this PR solve the issue on #63, making it possible to capture complex UpSet plot like:

upset(movies,attribute.plots=list(gridrows=60,plots=list(list(plot=scatter_plot, x="ReleaseDate", y="AvgRating"),
list(plot=scatter_plot, x="ReleaseDate", y="Watches"),list(plot=scatter_plot, x="Watches", y="AvgRating"),
list(plot=histogram, x="ReleaseDate")), ncols = 2))

BTW: ggplotify now supports converting upset to ggplot object, by using as.ggplot:

library(ggplotify) 
p2 <- as.ggplot(
	upset(movies,attribute.plots=list(gridrows=60,plots=list(
		list(plot=scatter_plot, x="ReleaseDate", y="AvgRating"),
		list(plot=scatter_plot, x="ReleaseDate", y="Watches"),
		list(plot=scatter_plot, x="Watches", y="AvgRating"),
		list(plot=histogram, x="ReleaseDate")), ncols = 2))
)

guangchuang yu added some commits Apr 24, 2018

guangchuang yu
@swuyts

This comment has been minimized.

Copy link

swuyts commented May 25, 2018

@GuangchuangYu
I just stumbled onto the fact that ggplotify can convert upset to ggplot. Is this also true for a plot without attribute.plots? Currently it throws this error for me:

Error in UseMethod("validGrob") : no applicable method for 'validGrob' applied to an object of class "NULL"

I'd like to use this function to apply the upset plot in a ggarrange call (ggpubr package)

@GuangchuangYu

This comment has been minimized.

Copy link
Author

GuangchuangYu commented May 27, 2018

ggplotify only works with github version of UpSetR + this PR.

@GuangchuangYu

This comment has been minimized.

Copy link
Author

GuangchuangYu commented May 27, 2018

image

@GuangchuangYu

This comment has been minimized.

Copy link
Author

GuangchuangYu commented May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment