-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Int8, Int16, and Int32 textures #372
Conversation
4d7d476
to
d40be5f
Compare
@manzt It's good that we agree with Napari. If you look at the picker tool in Avivator over those points, they are negative one, which causes the shader to render black simply because the output there is either less than 0 for the auto-slider values (which are 1 for each channel) or 0 if you move the slider to the min value of the domain (-1). But in theory, the sliders should be able to go from -127 -> 127 for this image (and they would be able to in Vitessce because we have the "Full" option). So we could have an image like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's add that min
option to DTYPE_VALUES
so this works nicely with Vitessce's "full" option. Thanks!
@ilan-gold I added a JSDoc |
Ok! Thanks! |
@manzt Will you update it in vizarr too? |
@oeway, yes when I get the chance. Hopefully this week, now that we've made a release. |
Just noticed with https://github.com/hms-dbmi/vizarr/pull/136/files that |
Fixes #370 more robustly..
The primary change in this PR is that we don't cast any TypedArrays unless there is no WebGL2 support. In addition, all of the handling of webgl2 vs webgl1 is isolated to just before creating a texture. This changes the previous behavior where both
ImageLayer
andMultiscaleImageLayer
checked for WebGL2, now it's done in once place:dataToTexture
.The main weirdness seems to be that the text is black on the example image. @ilan-gold, I'm not sure if you know why this is the case.