New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\pdf@shellescape breaks with --no-shell-escape in LuaLaTeX #45

Closed
PhelypeOleinik opened this Issue Aug 27, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@PhelypeOleinik

PhelypeOleinik commented Aug 27, 2018

This issue was spotted in this question.

The following code breaks when compiled with lualatex --no-shell-escape file.tex:

\documentclass{article}
\usepackage{pdftexcmds}
\makeatletter
\count@=\pdf@shellescape
\makeatother
\begin{document}
\end{document}

When compiled with --no-shell-escape LuaTeX returns a 0 which, at the moment \pdf@shellescape is defined, has \catcode 9, so it disappears and \pdf@shellescape expands to \numexpr \relax and it breaks with Missing number, treated as zero.

I thought that maybe doing a local \catcode change while defining \pdf@shellescape would be one way to solve it. Or maybe moving the definition a few lines below, where the \catcode of 0 is back to 12.

In the StackExchange chat Ulrike Fischer suggested to remove the \directlua0 thing and the compatibility ti LuaTeX < 0.36 altogether (with a very good argument).

davidcarlisle added a commit that referenced this issue Sep 8, 2018

@davidcarlisle

This comment has been minimized.

Show comment
Hide comment
@davidcarlisle

davidcarlisle Sep 8, 2018

Contributor

Thanks I think that should be fixed now, and it's anyway safer to use a fixed catcode regime in these internal sprint functions.

Contributor

davidcarlisle commented Sep 8, 2018

Thanks I think that should be fixed now, and it's anyway safer to use a fixed catcode regime in these internal sprint functions.

@davidcarlisle

This comment has been minimized.

Show comment
Hide comment
@davidcarlisle

davidcarlisle Sep 8, 2018

Contributor

last comment should have been issue #38

Contributor

davidcarlisle commented Sep 8, 2018

last comment should have been issue #38

@davidcarlisle davidcarlisle reopened this Sep 9, 2018

@davidcarlisle

This comment has been minimized.

Show comment
Hide comment
@davidcarlisle

davidcarlisle Sep 9, 2018

Contributor

the updated dtx has a changelog describing the fix, but not the fix, sorry, another update will be needed, re-opening.

Contributor

davidcarlisle commented Sep 9, 2018

the updated dtx has a changelog describing the fix, but not the fix, sorry, another update will be needed, re-opening.

davidcarlisle added a commit that referenced this issue Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment