Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop HHVM support #69

Closed
Hywan opened this issue Jul 4, 2017 · 11 comments

Comments

@Hywan
Copy link
Member

commented Jul 4, 2017

After a long discussion about #36:

  1. atoum has dropped support for HHVM,
  2. No one has asked for HHVM support,
  3. HHVM does not support PHP 7.

Progression

  • Acl,
  • Compiler,
  • Consistency,
  • Console,
  • Database,
  • Dispatcher,
  • Event,
  • Exception,
  • Graph,
  • Iterator,
  • Json,
  • Locale,
  • Mail,
  • Math,
  • Mime,
  • Protocol,
  • Registry,
  • Ruler,
  • Socket,
  • Stream,
  • Ustring,
  • View,
  • Visitor,
  • Websocket,
  • Zombie.

@Hywan Hywan added this to the Roadmap for 2017 milestone Jul 4, 2017

@Hywan Hywan self-assigned this Jul 4, 2017

@Grummfy

This comment has been minimized.

Copy link
Member

commented Jul 6, 2017

So we remove it totally from travis build?

@vonglasow

This comment has been minimized.

Copy link
Member

commented Jul 6, 2017

@Grummfy Yes, it was decided during the last virtual meeting.

@Grummfy

This comment has been minimized.

Copy link
Member

commented Jul 6, 2017

it was just be sure

Grummfy added a commit to Grummfy/Consistency that referenced this issue Jul 6, 2017

Grummfy added a commit to Grummfy/Console that referenced this issue Jul 6, 2017

@Hywan Hywan changed the title Drop HHVM Drop HHVM support Jul 7, 2017

Bhoat added a commit that referenced this issue Jul 7, 2017

[auto] Merge from Console
    • #a8fa11a — fix for #69 (Grummfy, 2017-07-06)

---

Merge branch 'master' of /var/lib/git/repositories/Library/Console

Bhoat pushed a commit that referenced this issue Jul 7, 2017

chore(ci) Drop HHVM support.
Fix for #69 on Consistency.

@Bhoat Bhoat closed this in 144b8a2 Jul 7, 2017

Bhoat added a commit that referenced this issue Jul 7, 2017

[auto] Merge from Acl
    • #144b8a2 — fix #69 for Acl (Grummfy, 2017-07-06)
    • #fda96d0 — chore(ci) Drop HHVM support (Grummfy, 2017-07-07)

---

Merge branch 'master' of /var/lib/git/repositories/Library/Acl

@ghost ghost removed the in progress label Jul 7, 2017

@Hywan Hywan added the in progress label Jul 7, 2017

@Hywan Hywan reopened this Jul 7, 2017

@fredemmott

This comment has been minimized.

Copy link

commented Jul 7, 2017

  1. What are you missing now? I'm not going to claim that it's enough for you to reconsider, but 3.20.2 has substantially improved support, including composer and phpunit in php7 mode. Travis doesn't have recent versions though.
@Hywan

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

@fredemmott That's a good question. Most of the tools we are using to ensure the quality inside Hoa does not support HHVM, especially atoum (or PHP CS Fixer for “minor” tools —minor for us, the tool is not minor). There are PR on atoum to add more support for HHVM (atoum/atoum#624, atoum/atoum#625) but this is not the end of the journey. Most projects are dropping their support for HHVM, like Symfony and Doctrine. Doctrine is going to use Hoa, and some Symfony bundles are using Hoa too. We were going to support HHVM because of these projects, but since they have dropped HHVM, we no longer have any commitments. This is the same story with Laravel and PsySH —which uses Hoa— etc.

tl;dr: Hoa is used by a lot of projects, that find their ways into major frameworks, like Symfony, Laravel, Zend, Doctrine etc. All these projects have dropped HHVM support, so this is no longer a requirement for us.

@Hywan

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

@fredemmott To be clear, this is not a move against HHVM. I am the lead dev of Tagua VM, an experimental PHP virtual machine. I know the amount of work it represents, and I can easily understand how it hurts when someone drops the support for your project. This is not against HHVM. This is us, with our limited resources, trying to provide the best we can to a large and attentive audience.

@fredemmott

This comment has been minimized.

Copy link

commented Jul 7, 2017

Yep, I'm just trying to get an idea of what PHP7 incompatibilities are most important, given the recent improvements and "HHVM does not support PHP 7."

@bobthecow

This comment has been minimized.

Copy link

commented Jul 12, 2017

This is the same story with Laravel and PsySH —which uses Hoa— etc.

PsySH does support HHVM, for what it's worth. It's an "allowed failure" in our CI right now, because testing it on Travis has been a bit flakier than all the other PHP versions, but it's definitely supported:

https://travis-ci.org/bobthecow/psysh/jobs/252780783

@Hywan

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2017

@bobthecow My mistake! Thank you for the notice!

@Grummfy

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

for information the only not migrated library are the one that have no travis inside so :

@Hywan Hywan closed this Aug 7, 2017

@ghost ghost removed the in progress label Aug 7, 2017

@Hywan

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2017

Great, thanks for your work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.