New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Write more test suites #89

Merged
merged 34 commits into from Sep 7, 2016
Commits
File filter...
Filter file types
Jump to file or symbol
Failed to load files and symbols.
+2 −1
Diff settings

Always

Just for now

Model: Move set auto laziness to `setName`.

With this patch, the auto laziness is computed when the name changes,
and no longer only on the constructor call.
  • Loading branch information...
Hywan committed Sep 2, 2016
commit 8f9e0e8b4808298c49d4caf6011a639eae980419
Copy path View file
@@ -104,7 +104,6 @@ public function __construct(
$isFunction = true
) {
$this->setName($name);
$this->setLaziness('and' === $name || 'or' === $name);
$this->setArguments($arguments);
$this->setFunction($isFunction);
@@ -122,6 +121,8 @@ protected function setName($name)
$old = $this->_name;
$this->_name = $name;
$this->setLaziness('and' === $name || 'or' === $name);
return $old;
}
ProTip! Use n and p to navigate between commits in a pull request.