/cargo-nono

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary feature names for conditional no_std support #1

Closed
gnzlbg opened this Issue Nov 12, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gnzlbg @hobofan
@gnzlbg

gnzlbg commented Nov 12, 2018

or the often used conditional #![cfg_attr(not(feature = "std"), no_std)]

libc and many other crates call this feature use_std
@hobofan

This comment has been minimized.

Sign in to view
Owner

hobofan commented Nov 12, 2018

👍

I think it should also be possible to make it work for any feature FEAT as long as it follows the #![cfg_attr(not(feature = "FEAT"), no_std)] syntax.

@hobofan hobofan referenced this issue Nov 13, 2018

Open

List of crates with wrong check results #4

hobofan added a commit that referenced this issue Nov 13, 2018

@hobofan
feat(check): check against list of known feature-gate names 
REFERENCE #1
c6194c0
@hobofan

This comment has been minimized.

Sign in to view
Owner

hobofan commented Nov 13, 2018

Support for this has been added in c6194c0, and released in version 0.1.1. There now is a builtin list of feature names to check for.

Support for any feature name is still the plan.

@hobofan hobofan changed the title use_std feature Support arbitrary feature names for conditional no_std support Nov 13, 2018

@hobofan hobofan closed this in 2391993 Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment