Permalink
Commits on Jan 18, 2017
  1. Update changelog

    hoelzro committed Jan 18, 2017
  2. Look under command line tools for SDK as well

    hoelzro committed Jan 18, 2017
    This way people don't need to install XCode to build
    and install the module
  3. Update META.yml

    hoelzro committed Jan 18, 2017
  4. Bump module version

    hoelzro committed Jan 18, 2017
Commits on Jan 2, 2017
  1. Update changelog

    hoelzro committed Jan 2, 2017
  2. Make sure we stop on DESTROY if we haven't stopped already

    hoelzro committed Jan 2, 2017
    Make sure we can clean up everything on the primary thread by
    cleaning up the child thread
  3. Clean up resources when we have errors

    hoelzro committed Jan 2, 2017
    Also move a bit of code around to make some
    error handling easier
    
    Also confine the lifetime of the mutex to that of the FSEvents
    object to make reasoning about its lifetime easier, plus to
    prevent resource leaks
  4. Refer to a copy of the respipe in watch()'s return

    hoelzro committed Jan 1, 2017
    The way this used was that we'd return a glob value that referred
    to the file descriptor for the results pipe we use to indicate new
    values from FSWatch.  The problem was that if you call stop(), that
    would close the pipe, invalidating the file descriptor, and a separate
    issue would cause that blob to hang around until global destruction
    time.
    
    Now we just dup() the file descriptor so that the glob value we return
    has its own file descriptor to close
Commits on Jan 1, 2017
  1. Fix compilation warnings

    hoelzro committed Jan 1, 2017
    These were harmless, but it doesn't hurt.
Commits on Dec 18, 2014
  1. Merge pull request #5 from preaction/master

    hoelzro committed Dec 18, 2014
    The Cleanup Stuff (and now everything else too)
  2. remove unnecessary gitignores

    preaction committed Dec 18, 2014
    No need to ignore these now that tests don't create them.
  3. upgrade ppport.h

    preaction committed Dec 18, 2014
    I tried to use av_top_index() like perlapi says I can, but it turns out
    this was added in 5.17 and does not work on the 5.12 I tested it on.
    
    ppport.h is the correct way to get new perlapi calls on older perls
  4. add watching multiple paths at once

    preaction committed Dec 18, 2014
    Now we can watch on any number of paths at once, making things a bit
    easier and more efficient.
    
    Fixes #100939
  5. add note about symbolic links in watched paths

    preaction committed Dec 18, 2014
    If the watched path is part of a symbolic link, the event path will not
    appear to be in the watched path. The event's path will be the real
    path.
  6. move flags into constructor arguments

    preaction committed Dec 18, 2014
    In addition to allowing a bitfield of flags, now we allow constructor
    args with the flag names. This way, users don't need to import the flag
    constants into their package, and they don't have to know how to
    construct a bitfield.
    
    Fixes #100940
  7. add docs about the flags available

    preaction committed Dec 18, 2014
    A short blurb about the flags so users know what they do. The Apple docs
    are a bit hard to navigate when the API presented by this module is so
    different.
    
    Fixes #100941
  8. explicitly define all dependencies

    preaction committed Dec 18, 2014
    And remove one that we don't need anymore
  9. remove dependency on File::Slurp

    preaction committed Dec 18, 2014
    We were only using it in a test, and there's a way to force FSEvents
    using just File::Temp.
  10. consolidate and reorder tests

    preaction committed Dec 18, 2014
    When we moved tests into xt/ it left a hole in the numbers. I also
    combined two test files and deleted one that is simply skipped (it's
    always in the git history if we need it again).
  11. make sure test tempdirs are automatically cleaned

    preaction committed Dec 18, 2014
    While doing this I found a fun thing: FSEvents always show the real
    path, after resolving any symlinks. The Cwd::abs_path function has to be
    used to find the real path. Doc patch forthcoming...
    
    I reduced some of the timeouts to make the tests a bit faster, but not
    nearly enough. I also had to add another sleep because the event queue
    sometimes goes slightly back in time.
    
    I rearranged t/06flags.t to make it easier to ensure the right tempdir
    is being kept around for the appropriate tests. The end result was fewer
    lines of code and a more linear flow.
  12. fix invalid overload test

    preaction committed Dec 18, 2014
    I don't know how this ever worked, but it certainly didn't test what I
    thought it did: setting path to an object that could be stringified.
Commits on Dec 17, 2014
  1. use new Test::More features

    preaction committed Dec 17, 2014
    subtest and done_testing make tests cleaner and easier to write. It does
    require Test::More 0.99 though.
    
    Fixes #100937
  2. update Makefile.PL with more modern EUMM features

    preaction committed Dec 17, 2014
    Now we can specify things like BUILD_REQUIRES, CONFIGURE_REQUIRES, and
    TEST_REQUIRES, so we can make test-only requirements that get handled
    correctly.
  3. update the manifest

    preaction committed Dec 17, 2014
    This is one of the build artifacts that should probably be better
    generated by Dist::Zilla
  4. whitespace and consistent code formatting

    preaction committed Dec 17, 2014
    This commit removes all trailing whitespace, converts all tabs to 4
    spaces (reindenting code as necessary), and ensures space consistency.
    
    Fixes #100935
  5. move code quality tests to xt/

    preaction committed Dec 17, 2014
    xt/ is the preferred place for "extra tests" that should not be run by
    users and therefore potentially impact the installability of the dist.
    
    Additionally, since they are only run on-demand, we can assume the
    person running it has installed the modules they require.
    
    Fixes #100938
Commits on Dec 15, 2014
  1. Merge pull request #4 from preaction/constructor-options

    hoelzro committed Dec 15, 2014
    Add single argument (path) constructor
Commits on Dec 14, 2014
  1. document new constructor options

    preaction committed Dec 14, 2014
    Document the new non-ref and single path argument variations of the
    constructor.
  2. allow single argument (path) to constructor

    preaction committed Dec 14, 2014
    Now the simplest case is just Mac::FSEvents->new( $path );
  3. Merge pull request #3 from preaction/constructor-options

    hoelzro committed Dec 14, 2014
    Constructor options
  4. Bump version to 0.12

    hoelzro committed Dec 14, 2014