New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues with lib name generation #19

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@ugexe
Contributor

ugexe commented Jan 2, 2017

This fixes a problem where automatic library name generation is
used, but part of the generated library name is hardcoded else-
where. This resulted in the build failing on windows, because
the hardcoded portion was not applicapable.

Note that while this allows Linenoise to be installed on windows
once again, it still does not work properly. This is because libs
that get installed have their file names mangled, but I think the
linenoise.dll file needs to have the same name? (some missing
symbol error gets thrown). OpenSSL had this problem, which it works
around with lib/OpenSSL/NativeLib.pm6

Fixes issues with lib name generation
This fixes a problem where automatic library name generation is
used, but part of the generated library name is hardcoded else-
where. This resulted in the build failing on windows, because
the hardcoded portion was not applicapable.

Note that while this allows Linenoise to be installed on windows
once again, it still does not work properly. This is because libs
that get installed have their file names mangled, but I think the
linenoise.dll file needs to have the same name? (some missing
symbol error gets thrown). OpenSSL had this problem, which it works
around with lib/OpenSSL/NativeLib.pm6

@hoelzro hoelzro merged commit 5ad3689 into hoelzro:master Jan 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hoelzro

This comment has been minimized.

Owner

hoelzro commented Jan 5, 2017

@ugexe Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment