Build proper release binaries by default #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because -fprofile-arcs causes non-determinism via https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96970 and release binaries should not be instrumented like this anyway. This PR was done while working on reproducible builds for openSUSE.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 36 36
Lines 3307 3307
=======================================
Hits 2809 2809
Misses 498 498 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Build proper release binaries by default
Because
-fprofile-arcsintroduces non-determinism viahttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=96970
and release binaries should not be instrumented like this anyway.
This change makes life easier for distribution packagers.
This PR was done while working on reproducible builds for openSUSE.