Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_text_point #2293

Closed

Conversation

SamuMazzi
Copy link
Contributor


name: Fix add_text_point
about: Create a pull request to help us improve
title: Fix add_text_point


Description:
The add_text_point() function used to throw an exception when called because of a simple error during the parsing of the parameters.
That has been fixed, but it also has been changed x_offset and y_offset which have been brought to the same variable offset. Actually these variables didn't have a default value then they used to make throw an exception if not specified.

Also the type notation of the x and y values have been changed according on how they are handled in the code.

Fixes #2108

@SamuMazzi
Copy link
Contributor Author

Fixed in #2275

@SamuMazzi SamuMazzi closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_text_point raises exceptions even when used with only required inputs
1 participant