Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second pass at support for graphical models in stabs, with commits sq… #14

Merged
merged 1 commit into from Sep 22, 2016

Conversation

@richardbeare
Copy link
Contributor

@richardbeare richardbeare commented Sep 22, 2016

…uashed

Graphical modelling behaviour is controlled by a class attribute on the fitfun.

Use can supply a lambda path. This is to deal with the scenario of not finding
the required number of variables.

I've put this in a separate branch to clear things up a bit and see if the testing works.

I think the argument handling is now what you're after, and there are some tests of this
behaviour.

I've continued to export getLamPath as I now have an option for the user to supply the path.

The package passes devtools::check

…uashed

Graphical modelling behaviour is controlled by a class attribute on the fitfun.

Use can supply a lambda path. This is to deal with the scenario of not finding
the required number of variables.
@hofnerb
Copy link
Owner

@hofnerb hofnerb commented Sep 22, 2016

I've moved your changes with a few modifications into a new branch.

However, currently the checks don't pass (see appveyor and travis-ci) as QUIC is said to be missing. I do not really understand this. It also happens if I check the package locally but not if I run the tests manually in an interactive session.

If you have any ideas please let me know. Once I've solved this issue I will merge the changes into the main repository.

@hofnerb hofnerb merged commit 834c6d0 into hofnerb:master Sep 22, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@richardbeare
Copy link
Contributor Author

@richardbeare richardbeare commented Sep 22, 2016

Yes, I noticed that - I was hoping you'd recognise it. I'll try to track
the issue down.

On Fri, Sep 23, 2016 at 1:53 AM, Benjamin Hofner notifications@github.com
wrote:

Merged #14 #14.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAvooVwXaON_bpEBFRJ9VvRq1x7sPQeCks5qsqR9gaJpZM4KDbv4
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.