Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix error True/False is expected but vector is received in assertion #17
Conversation
|
Thank you for the fix. I have to say that I did not see an exception (under R 3.3.2 and earlier versions) but you are right that the old code does not test the stated. Note that I will merge your pull request but loosen the check afterwards as it is sufficient that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The previous code was always triggering an exception (R 3.3.1) when evaluating the if() statement because a vector was used on the right hand side of a logical && predicate. Additionally, the logical predicate itself was incorrect according to the meaning of the error message in the stop() call.
Also, the modified expression is now more generic because it allows for the presence of other names in the res list in addition to the two names that are required to be present.