New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php7 signature #2

Merged
merged 4 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@ssahara
Copy link
Contributor

ssahara commented May 23, 2018

This PR should prevent unwanted php warning messages:

Declaration of syntax_plugin_ruby::handle($match, $state, $pos, &$handler) should be compatible
  with DokuWiki_Syntax_Plugin::handle($match, $state, $pos, Doku_Handler $handler)
Declaration of syntax_plugin_ruby::render($mode, &$renderer, $data) should be compatible 
  with DokuWiki_Syntax_Plugin::render($format, Doku_Renderer $renderer, $data)

ssahara added some commits May 23, 2018

Adjust method signatures to match parent
to prevent php warnings in php_error.log
omit the PHP closing tag at the end of the file
This prevents accidental whitespace or new lines being added after the
PHP closing tag, which may cause unwanted effects because PHP will start
output buffering when there is no intention from the programmer to send
any output at that point in the script.
see http://php.net/manual/en/language.basic-syntax.phptags.php

@hokkaidoperson hokkaidoperson merged commit cbc416c into hokkaidoperson:master May 23, 2018

@hokkaidoperson

This comment has been minimized.

Copy link
Owner

hokkaidoperson commented May 23, 2018

Thank you for modifying my plugin!
I merged your requests.

@ssahara ssahara deleted the ssahara:php7-signature branch May 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment