Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using koin context isolation #20

Closed
holgerbrandl opened this issue Nov 15, 2021 · 1 comment
Closed

Consider using koin context isolation #20

holgerbrandl opened this issue Nov 15, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@holgerbrandl
Copy link
Owner

Instead of the custom model we should use context isolation to provide DI per simulation

https://insert-koin.io/docs/reference/koin-core/context-isolation/

@holgerbrandl holgerbrandl added the enhancement New feature or request label Nov 15, 2021
@holgerbrandl holgerbrandl self-assigned this Nov 15, 2021
@holgerbrandl
Copy link
Owner Author

Alternatively, we could bind the koin scope to the thread.

Constraining the koin scope to the is unlikely to work because of the common Environment().apply pattern (unless we would overload apply itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant