Browse files

cleanup log message when a non-managed option is passed to mysqldump

A set of mysqldump options are scanned by holland and some basic
safety checks enforced. e.g. flush-privileges isn't supported on mysql 4.1
and dump-events is not supported on 5.0, etc.  When a user passes an explicit
option via additional-options that the mysqldump plugin does not recognize
we flag this as either an 'unparseable option' - which may cause mysqldump to
fail or as a 'user supplied option' - if it looks valid but holland doesn't
have any special check for it.
  • Loading branch information...
abg committed Oct 15, 2012
1 parent 024c271 commit 992db6a5715781197236325d8ad1c6fb7993d336
Showing with 2 additions and 2 deletions.
  1. +2 −2 plugins/holland.backup.mysqldump/holland/backup/mysqldump/
@@ -47,12 +47,12 @@ def check_option(self, option):
option, arg =
except AttributeError:
- raise MyOptionError("Unsupported option %r" % option)
+ raise MyOptionError("Unparseable option '%s'" % option)
option = option.replace('_', '-')
if option not in self._options:
- raise MyOptionError("Unsupported option %r" % option)
+ raise MyOptionError("User supplied option '%s'" % option)
my_option = self._options[option]
my_option.check(self.version, arg)

0 comments on commit 992db6a

Please sign in to comment.