New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing to perlcritic severity 3, and fixed build process based on my local build. #1

Merged
merged 8 commits into from Jan 23, 2015

Conversation

Projects
None yet
2 participants
@manchicken
Contributor

manchicken commented Jan 12, 2015

I improved the build process per my local configuration which is closer to a default Ubuntu build. Also improved the code to meet perlcritic severity 3.

@manchicken

This comment has been minimized.

Show comment
Hide comment
@manchicken

manchicken Jan 16, 2015

Contributor

@holly, I have updated my pull request and it now builds and passes in Travis CI. I've been looking at other things to do with this module, and I'm trying to think of whether or not there's anything you'd like me to do.

Much thanks.

Contributor

manchicken commented Jan 16, 2015

@holly, I have updated my pull request and it now builds and passes in Travis CI. I've been looking at other things to do with this module, and I'm trying to think of whether or not there's anything you'd like me to do.

Much thanks.

holly added a commit that referenced this pull request Jan 23, 2015

Merge pull request #1 from manchicken/master
Enhancing to perlcritic severity 3, and fixed build process based on my local build.

@holly holly merged commit d6068ad into holly:master Jan 23, 2015

@holly

This comment has been minimized.

Show comment
Hide comment
@holly

holly Jan 23, 2015

Owner

Thanks!

Owner

holly commented Jan 23, 2015

Thanks!

@manchicken

This comment has been minimized.

Show comment
Hide comment
@manchicken

manchicken Jan 23, 2015

Contributor

Thank you!

On Thu, Jan 22, 2015 at 8:17 PM, holly notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#1 (comment)
.

~ Michael D. Stemle, Jr.

Contributor

manchicken commented Jan 23, 2015

Thank you!

On Thu, Jan 22, 2015 at 8:17 PM, holly notifications@github.com wrote:

Thanks!


Reply to this email directly or view it on GitHub
#1 (comment)
.

~ Michael D. Stemle, Jr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment