Did you mean #91

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@romainberger
Contributor

romainberger commented Jul 9, 2013

Hi Zach,

This is a follow up on my previous pull request (#90), as my basic idea was not only to display a proper error but also a 'did you mean' thing à la git when you type something that does not exist. I wanted to add this as I never remember how I named my items.
So I played with the idea and implemented it. Feel free to refuse the pull request if you think this is an overkill as it adds another dependency.

Basically when you try to copy or open an item that does not exist you get this:

$ boom log
Couldn't find log.
Did you mean this?
    blog
@holman

This comment has been minimized.

Show comment
Hide comment
@holman

holman Jul 9, 2013

Owner

Yeah- cool idea, but I'm kind of -1 on adding more dependencies (particularly since if I ever switch this from Ruby it'll be a bit more of a pain). I could potentially see this as a simple grep operation, but I think it might be a little feature creep for now.

Thanks for the pull, though!

Owner

holman commented Jul 9, 2013

Yeah- cool idea, but I'm kind of -1 on adding more dependencies (particularly since if I ever switch this from Ruby it'll be a bit more of a pain). I could potentially see this as a simple grep operation, but I think it might be a little feature creep for now.

Thanks for the pull, though!

@holman holman closed this Jul 9, 2013

@romainberger

This comment has been minimized.

Show comment
Hide comment
@romainberger

romainberger Jul 9, 2013

Contributor

I get it. I wanted to try adding this without gem but that was more complicated than I thought and didn't wanted to re-invent the wheel.
Anyway that was fun, no hard feelings

Contributor

romainberger commented Jul 9, 2013

I get it. I wanted to try adding this without gem but that was more complicated than I thought and didn't wanted to re-invent the wheel.
Anyway that was fun, no hard feelings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment