Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

More verbose install script and pretty prints #149

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

OmeGak commented May 18, 2014

I wanted to have prettier and more robust install.sh scripts. For that I made the main install script cleaner and more verbose and encapsulated the prints used in script/bootstrap along with some others for intermediate steps in bin/pprint.

To have as reference, I also updated homebrew and ruby install scripts with pretty prints and redirecting output to *.dot.log files. that will be listed at the end of the install script in case there were any problem.

More verbose install script and pretty prints
* Install script is more verbose
* Install script prints list of dot.log files created
* Pretty prints bundled for use with install.sh files
Contributor

kirelagin commented May 19, 2014

I was going to suggest using gentoo-functions (or, at least, parts of it) because it does proper escape-codes detection…

Contributor

OmeGak commented May 20, 2014

I could give it a shot. How would you go about it? curl-ing them from gentoo repo as a hard dependency or just adding the whole/part of the file in dotfiles?

Contributor

kirelagin commented May 23, 2014

I'm not sure @holman will be 😄 to have an additional dependency. And I'm definitely not in favour of curling. Copying the whole file is an option; or maybe just 🍒-picking the escape codes detection stuff is better. I'd go with the whole file for ease of maintenance, but, again, @holman has the final word.

Owner

holman commented Dec 16, 2014

There's some conflicts here on this one now... beyond that I think I'm going to keep more of a simpler approach (I'm not sure we need to extract all this out right now). I'll keep thinking on it, though; definitely food for thought!

@holman holman closed this Dec 16, 2014

Contributor

OmeGak commented Dec 16, 2014

No problem! I'll keep it in my fork if you ever come back to the idea.

@OmeGak OmeGak deleted the OmeGak:pprint branch Mar 22, 2016

timrcoulson pushed a commit to timrcoulson/dotfiles that referenced this pull request Mar 23, 2017

.gitattributes: Disable normalizing line endings globally
Instead of removing `~/.gitattributes` completely, I decided to just comment out the `* text=auto` line. This makes it easier to temporarily re-enable the setting should I ever want to.

Closes #149.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment