Fixes for "international" issues I found #3

Merged
merged 1 commit into from Oct 12, 2011

Conversation

Projects
None yet
2 participants
@dzacarias
Contributor

dzacarias commented Oct 2, 2011

  • I'm on GMT (Lisbon, Portugal) and the option selection code didn't work when there were 0 hours difference from GMT (no options have that text)
  • Garmin Connect seems to log us out after posting around 25 runs. Added code to catch the exception, log back in and carry on.
  • I have different date, time and number formats than the defaults. Added code to get the user's preferences from the settings page and format those types accordingly. Garmin's site expects the input to follow the user's settings.
Daniel Zacarias
Solves 3 issues I encountered:
* I'm on GMT and the option selection code didn't work when there were 0 hours difference
  from GMT (no options have that text)
* Garmin seems to log us out after posting some runs. Added code to catch the exception,
  log back in and carry on.
* I have different date, time and number formats than the defaults. Added code to get the
  user's preferences from the settings page and format those types accordingly.
  Garmin's site expects the input to follow the user's settings.
@holman

This comment has been minimized.

Show comment
Hide comment
@holman

holman Oct 12, 2011

Owner

This looks sharp. Merging. Thanks!

Owner

holman commented Oct 12, 2011

This looks sharp. Merging. Thanks!

holman added a commit that referenced this pull request Oct 12, 2011

Merge pull request #3 from dzacarias/master
Fixes for "international" issues I found

@holman holman merged commit e3ddc4a into holman:master Oct 12, 2011

@holman

This comment has been minimized.

Show comment
Hide comment
@holman

holman Oct 12, 2011

Owner

There's a new version of fatigue on RubyGems now, too.

Owner

holman commented Oct 12, 2011

There's a new version of fatigue on RubyGems now, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment