Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Cargos fingerprint data to trim to only install rust versions #14
Conversation
Eh2406
added some commits
Dec 16, 2018
This comment has been minimized.
This comment has been minimized.
|
The code looks very good, however, it seems to be crashing on Linux environment. Is rustup not available on Travis for Linux systems I wonder? Or is it something obvious I am missing? |
This comment has been minimized.
This comment has been minimized.
|
Looks like rustup is available in travisce, maybe it has something to do with cross? If we can't get the tests to work on CI, we can just remove them, they are not testing very much. (it makes me feel dirty to say it.) |
Eh2406
referenced this pull request
Dec 21, 2018
Merged
don't write a an incorrect rustc version to the fingerprint file #6473
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Dec 21, 2018
This comment has been minimized.
This comment has been minimized.
|
I removed the tests. They were only testing that reading the data from rustup was not crashing. And that is not a particularly finicky part of the code. |
This was referenced Dec 23, 2018
Merged
holmgr
merged commit 2a66c0d
into
holmgr:master
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Eh2406 commentedDec 20, 2018
This is the PR discussed in #6 (comment), specifically it used cargos fingerprint files and folder structure to let you
cargo +stable build && cargo +nightly build && rustup toolchain remove nightly && cargo sweep -iand it will remove all the files related to nightly leaving you with the same files as if you had only runcargo +stable build. (Witch a lot of peepal need to clean the cache folder on CI when nightly updates. like rust-lang/crates.io#1578)