Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint atime #16

Merged
merged 6 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@Eh2406
Copy link
Contributor

Eh2406 commented Dec 27, 2018

This builds on and includes #14. As discussed in #6 (comment), Cargo always reads the hash file in the fingerprint folder for the full transitive set of depended artifacts for every build. Thus the max atime in the fingerprint folder is the most reliable measure of witch artifacts are stale. And it is reliable enough to use with the -s argument.

@Eh2406

This comment has been minimized.

Copy link
Contributor Author

Eh2406 commented Jan 3, 2019

I know that it is hard to keep up with OSS with the holidays. Nonetheless, I would appreciate some response to my PRs. If my experiments for how a GC can work as a cargo subcommand are out of scope for this project I understand and will reach out to other projects. If I do not hear from you in the next week I will assume this is out of scope.

@holmgr

This comment has been minimized.

Copy link
Owner

holmgr commented Jan 3, 2019

Decided to stay clear of coding during the holidays to really relax for a while but have slowly started coming back to it, but I have a bit of a backlog of things to handle :P
Your PR looks very good to me.

@holmgr holmgr merged commit 87ba0fc into holmgr:master Jan 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Eh2406

This comment has been minimized.

Copy link
Contributor Author

Eh2406 commented Jan 3, 2019

Thanks for getting back to me. That is entirely reasonable, I hope it was relaxing!

@holmgr

This comment has been minimized.

Copy link
Owner

holmgr commented Jan 3, 2019

Oh, it certainly was, hopefully, you had a wonderful holiday yourself!

@Eh2406 Eh2406 deleted the Eh2406:fingerprint-atime branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.